[SampleApp] Preserve launch metadata and window placement across theme switches#569
Merged
Anna Malchow-Perryman (apman) merged 2 commits intoJun 29, 2026
Merged
Conversation
Carry over window position, size, and state when recreating MainWindow during theme changes so the app stays on the same monitor instead of returning to the primary display. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Anna Malchow-Perryman (apman)
June 29, 2026 17:29
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the SampleApp’s theme-switch experience by keeping launch metadata (branch/time) stable across window recreation and restoring the window’s previous placement when MainWindow is recreated due to a theme change.
Changes:
- Cache launch time and git branch once per process so the title doesn’t refresh on theme-triggered window recreation.
- Capture and reapply window placement (position, size, window state) when recreating
MainWindowduring theme changes. - Force
WindowStartupLocation.Manualon recreation to avoid reopening centered on the primary display.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| samples/SampleApp/MainWindow.axaml.cs | Caches launch time/branch and reuses them when rebuilding the window title after theme-driven recreation. |
| samples/SampleApp/App.axaml.cs | Captures old window placement and applies it to the newly created MainWindow to preserve monitor/size/state across theme switches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MainWindowon theme changes (position, size, and window state)Why
Switching themes intentionally recreates the window. Before this change, that caused:
This PR keeps both pieces of context stable across theme switches.
Validation
dotnet testpassed (124/124)Notes
Normalto avoid reopening minimized.