Merged
Conversation
southeo
reviewed
Mar 31, 2026
| "$ref": "https://schemas.dissco.tech/schemas/fdo-type/shared-model/0.4.0/target-digital-object-filter.json" | ||
| }, | ||
| "ltc:hasGeographicContext": { | ||
| "ods:hasSignificanceForCountries": { |
Contributor
There was a problem hiding this comment.
If this is just an array of primatives it should be
ods:significanceForCountries
has -> implies object
Contributor
Author
There was a problem hiding this comment.
So sorry, that is on me. Doing too many things at the same time (and then wasting yours 😞 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided not to reuse the
ltcterm but mind a ods term.The
ltc:hasGeographicalContexthas a different meaning and is aimed specifically at the geographical context of the specimen in the VirtualCollection.The ods term shows for which specific country the VC is significant for, the collecting country of the specimen can be different.