feat: Log connected devices when using deviceManager #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 43 43
Lines 2780 2781 +1
=======================================
+ Hits 2642 2643 +1
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
changed the title
keithralphs
reviewed
Jan 30, 2026
Contributor
keithralphs
left a comment
keithralphs
left a comment
There was a problem hiding this comment.
Looks good, just needs the conflict resolving
tpoliaw
force-pushed
the
report-devices
branch
from
aa868a0 to
7340c01
Compare
keithralphs
approved these changes
Jan 30, 2026
Contributor
keithralphs
left a comment
keithralphs
left a comment
There was a problem hiding this comment.
All good now, please merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report_successful_devices function should be moved when the dodal
module support is removed but it can stay where it is for now.