This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Add helm chart for postgresql database#382
Open
iamvigneshwars wants to merge 4 commits intoDiamondLightSource:mainfrom
Open
Add helm chart for postgresql database#382iamvigneshwars wants to merge 4 commits intoDiamondLightSource:mainfrom
iamvigneshwars wants to merge 4 commits intoDiamondLightSource:mainfrom
Conversation
iamvigneshwars
added
enhancement
iamvigneshwars
force-pushed
the
postgres-helm-chart
branch
2 times, most recently
from
5fc863f to
6b41921
Compare
iamvigneshwars
force-pushed
the
postgres-helm-chart
branch
2 times, most recently
from
3d8cc64 to
5b8db2d
Compare
iamvigneshwars
force-pushed
the
postgres-helm-chart
branch
from
5b8db2d to
a8fd852
Compare
garryod
suggested changes
Mar 7, 2024
Contributor
garryod
left a comment
garryod
left a comment
There was a problem hiding this comment.
Think the sealed secrets could just be secrets with randAlphaNum as we don't need them outside the deployment at all
iamvigneshwars
force-pushed
the
postgres-helm-chart
branch
3 times, most recently
from
49269be to
4efcbad
Compare
garryod
suggested changes
Mar 13, 2024
Contributor
garryod
left a comment
garryod
left a comment
There was a problem hiding this comment.
Could we set up metrics and have them scraped by prometheus?
charts/xchemlab/values.yaml
Outdated
| database: | ||
| host: postgres://postgresql-ha-pgpool | ||
| user: postgres | ||
| host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local |
Contributor
There was a problem hiding this comment.
Do we need to template this with the deployment name?
charts/xchemlab/values.yaml
Outdated
| database: | ||
| host: postgres://postgresql-ha-pgpool | ||
| user: postgres | ||
| host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local |
Contributor
There was a problem hiding this comment.
Do we need to template this with the deployment name?
charts/xchemlab/values.yaml
Outdated
| database: | ||
| host: postgres://postgresql-ha-pgpool | ||
| user: postgres | ||
| host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local |
Contributor
There was a problem hiding this comment.
Do we need to template this with the deployment name?
charts/xchemlab/values.yaml
Outdated
| database: | ||
| host: postgres://postgresql-ha-pgpool | ||
| user: postgres | ||
| host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local |
Contributor
There was a problem hiding this comment.
Do we need to template this with the deployment name?
charts/xchemlab/values.yaml
Outdated
| database: | ||
| host: postgres://postgresql-ha-pgpool | ||
| user: postgres | ||
| host: postgres://xchemlab-postgresql-ha-pgpool.xchemlab.svc.cluster.local |
Contributor
There was a problem hiding this comment.
Do we need to template this with the deployment name?
charts/xchemlab/values.yaml
Outdated
Comment on lines
171
to
176
| db-init.sql: | | ||
| SELECT 'CREATE DATABASE compound_library' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'compound_library')\gexec; | ||
| SELECT 'CREATE DATABASE compound_soaking' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'compound_soaking')\gexec; | ||
| SELECT 'CREATE DATABASE crystal_library' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'crystal_library')\gexec; | ||
| SELECT 'CREATE DATABASE targeting' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'targeting')\gexec; | ||
| SELECT 'CREATE DATABASE pin_packing' OWNER xchemlab WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'pin_packing')\gexec; |
Contributor
There was a problem hiding this comment.
Are we able to move this to a configmap / secret somehow? Just to tidy up the values file
iamvigneshwars
force-pushed
the
postgres-helm-chart
branch
from
4efcbad to
2674b0d
Compare
iamvigneshwars
force-pushed
the
postgres-helm-chart
branch
3 times, most recently
from
0e25a1f to
f0e8807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.