This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Open
Conversation
iamvigneshwars
added
enhancement
garryod
suggested changes
Mar 13, 2024
iamvigneshwars
force-pushed
the
subgraph-github-actions
branch
from
30e6504 to
741b027
Compare
garryod
reviewed
Mar 19, 2024
|
|
||
| - name: check subgraph schema | ||
| if: ${{ matrix.service.publish }} | ||
| uses: danielsinclair/rover-setup@v1 |
Contributor
There was a problem hiding this comment.
Can we use a fully qualified version?
garryod
reviewed
Mar 19, 2024
Comment on lines
+60
to
+62
| args: subgraph check xchemlab@current | ||
| --schema ${{ matrix.service.name }}.graphql | ||
| --name ${{ matrix.service.name }} |
Contributor
There was a problem hiding this comment.
Suggested change
| args: subgraph check xchemlab@current | |
| --schema ${{ matrix.service.name }}.graphql | |
| --name ${{ matrix.service.name }} | |
| args: | | |
| subgraph check xchemlab@current | |
| --schema ${{ matrix.service.name }}.graphql | |
| --name ${{ matrix.service.name }} |
garryod
reviewed
Mar 19, 2024
Comment on lines
+70
to
+73
| args: subgraph publish xchemlab@current | ||
| --routing-url http://${{ matrix.service.name }}:80 | ||
| --schema ${{ matrix.service.name }}.graphql | ||
| --name ${{ matrix.service.name }} |
Contributor
There was a problem hiding this comment.
Suggested change
| args: subgraph publish xchemlab@current | |
| --routing-url http://${{ matrix.service.name }}:80 | |
| --schema ${{ matrix.service.name }}.graphql | |
| --name ${{ matrix.service.name }} | |
| args: | | |
| subgraph publish xchemlab@current | |
| --routing-url http://${{ matrix.service.name }}:80 | |
| --schema ${{ matrix.service.name }}.graphql | |
| --name ${{ matrix.service.name }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.