-
Notifications
You must be signed in to change notification settings - Fork 115
Add extra mouse event handling #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixed those issues with this newest commit, although the Instant is still where it was initially |
nicoburns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left comments on a couple of important-but-trivial nits. And clippy/rustfmt need to be fixed. Other than that this it looking pretty close now?
|
Okay I'm not too sure why running cargo clippy on my machine didn't show that issue |
You may need to run |
|
Is there anything else you're still planning to do with this PR (it's still marked as a draft)? The only thing I'm currently tracking is the extra |
|
Yeah nothing else, I must have missed that extra redraw. I'll remove it and change the PR from draft. |
The following events now work with attributes:
I did move the actual scroll handling code into handle_scroll, but it means redraw happens on every wheel event now, which is not ideal.