-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: update examples to tailwind v4 #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jkelleyrtp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I see several package.json and package-lock.json files being generated....
I believe we don't need those - the tailwind CLI should be able to work without it.
Do you mind removing those and/or updating any docs to match?
|
Hi @jkelleyrtp 👋 Thank you for the review!
That has not been my experience. I had to run Do you mind sharing your setup / steps, just so I can confirm and update accordingly? 🙏 |
I've tested it and can confirm the The Tailwind CSS Standalone CLI does not need a package.json. See https://tailwindcss.com/blog/standalone-cli |
|
It depends how you install the tailwind CLI. If you run the CLI via npx which is the default in the tailwind docs then the new version does get installed in your node modules. If you use the standalone CLI, it does not. The other two PRs that update tailwind (DioxusLabs/dioxus-template#68 and DioxusLabs/docsite#473) both use the npx CLI |
* feat: update examples to tailwind v4 --------- Co-authored-by: Jonathan Kelley <[email protected]>
* feat: update examples to tailwind v4 --------- Co-authored-by: Jonathan Kelley <[email protected]>
Context
What changed?
examples/tailwindto use V4 Tailwind CSS CLItailwind.config.jsas it is unnecessary for V4 with a minimal setupexample-projects/ecommerce-siteto use V4 Tailwind CSS CLISee also