fix(php): give grouped function and const imports their own identity

[DivyamTalwar]

Problem

PHP grouped symbol imports are misclassified as class imports.

Given use function App\Helpers\{slug as s};, the alias s is recorded in the class-use map. The resolver then mints a sourceless App\Helpers\slug class node and points the file's imports edge at it instead of retaining the symbol target. A function import acquires a class-style graph identity it should never have had.

Root cause

_record_use_clause in graphify/extractors/resolution.py decided "is this a class import?" by scanning the clause's own children for a function or const token, returning early if it found one.

For a grouped import, tree-sitter attaches that token to the parent declaration, not to the nested clause. The nested clause therefore never sees it, the guard never fires, and the grouped symbol import falls through into the class path.

The guard was correct for ungrouped imports and structurally blind to grouped ones.

Approach

Propagate the declaration-level kind into the clauses beneath it.

• _record_use_clause takes a declaration_kind, supplied by the caller that already knows whether the declaration said function or const.
• The early return on encountering the token becomes clause_kind = c.type, so a token on the clause itself is still honoured and now records rather than aborts.
• The not-a-class-import decision moves to after parsing, keyed on the resolved clause_kind.

That ordering is the fix. Deciding before parsing is what made the original blind to a token living one level up.

Verification

The failing test was written and committed before the fix, so the fix is falsifiable:

f6e8f07  test: add failing regression for grouped PHP symbol imports
52b39a6  fix: propagate PHP symbol import kind across use clauses

Eight regression tests cover grouped aliases, mixed class-and-function groups, multi-namespace files, and a same-named class and function in one group.

The repository's own CI gate, run on this branch:

PASS  skillgen --check
PASS  skillgen --audit-coverage
PASS  skillgen --schema-singleton
PASS  skillgen --monolith-roundtrip
PASS  skillgen --always-on-roundtrip
PASS  pytest tests/ -q  ->  5509 passed, 13 skipped, 6 warnings in 90.94s

The same blocking set was green on v8 before this change, so none of that is inherited.

Impact

Grouped function and const imports keep their symbol identity and stop creating false class nodes. Class imports are unaffected: the guard still fires for them, just later in the same function.

Risk and rollback

Confined to one helper and its callers in the PHP resolution path. No schema change, no migration, no public API change. Reverting the second commit restores the previous behaviour exactly, and the tests from the first commit would then go red, which is why they are committed separately.

The case to watch is a declaration whose kind disagrees with a token on the clause itself. The clause token wins as the more specific statement, and test_php_symbol_import_kind_applies_to_all_declaration_clauses pins that.

[DivyamTalwar]

Superseded by the upstream contribution: Graphify-Labs#3466. This fork-internal PR was opened before the target was corrected to the original repository; the branch and commits are unchanged.