Qual: Make $fields covariant, define type for $FIELDS in BankAccounts api

[mdeweerd]

Qual: Make $fields covariant, define type for $FIELDS in BankAccounts api

• Make $fields covariant
• Define type for $FIELDS in BankAccounts api

[mdeweerd]

FYI: script used to update type for $fields:
updateCommonObjectFields.sh

#!/bin/bash -xv
# shellcheck disable=2016,2317
OLD='array<string,array{type:string,label:string,langfile?:string,enabled:int<0,2>|string,position:int,no
tnull?:int,visible:int<-6,6>|string,alwayseditable?:int<0,1>|string,noteditable?:int<0,1>,default?:string
,index?:int,foreignkey?:string,searchall?:int<0,1>,isameasure?:int<0,1>,css?:string,cssview?:string,cssli
st?:string,help?:string,showoncombobox?:int<0,4>|string,disabled?:int<0,1>,arrayofkeyval?:array<int|strin
g,string>,autofocusoncreate?:int<0,1>,comment?:string,copytoclipboard?:int<1,2>,validate?:int<0,1>,showon
header?:int<0,1>}>'
NEW='array<string,array{type:string,label:string,langfile?:string,enabled:int<0,2>|string,position:int,no
tnull?:int,visible:int<-6,6>|string,alwayseditable?:int<0,1>|string,noteditable?:int<0,1>,default?:string
,index?:int,foreignkey?:string,searchall?:int<0,1>,isameasure?:int<0,1>,css?:string,cssview?:string,cssli
st?:string,help?:string,showoncombobox?:int<0,4>|string,disabled?:int<0,1>,arrayofkeyval?:array<int|strin
g,string>,autofocusoncreate?:int<0,1>,comment?:string,copytoclipboard?:int<1,2>,validate?:int<0,1>,showon
header?:int<0,1>,searchmulti?:int<0,1>}>'
git grep -l -- "$OLD" htdocs | \
        xargs perl -i -p -e 's@array<[^ ]*?autofocusoncreate[^ ]*?>(\s[^\$>]*)$@'"$NEW"'$1@'