Skip to content

Conversation

@hregis
Copy link
Contributor

@hregis hregis commented Nov 9, 2025

No description provided.

@hregis hregis requested a review from eldy November 9, 2025 17:00
@hregis
Copy link
Contributor Author

hregis commented Nov 9, 2025

@eldy why not my fix ? #36195

@eldy
Copy link
Member

eldy commented Nov 9, 2025

@eldy why not my fix ? #36195

Conflict with another fix already done.

@hregis hregis force-pushed the fix_dev_member_photo_with_web_portal branch from b218467 to f6cfaa2 Compare November 9, 2025 18:17
@hregis hregis marked this pull request as draft November 10, 2025 07:31
@hregis
Copy link
Contributor Author

hregis commented Nov 10, 2025

@frederic34 you see a solution ?

@hregis hregis marked this pull request as ready for review November 10, 2025 09:28
@hregis hregis changed the title FIX member photo with web portal don't need login FIX member photo not deleted in documents directory Nov 10, 2025
@hregis
Copy link
Contributor Author

hregis commented Nov 10, 2025

@eldy i change my PR
photo of member not deleted in documents directory

@frederic34
Copy link
Member

@hregis what was the question ?

@hregis
Copy link
Contributor Author

hregis commented Nov 10, 2025

@frederic34

@hregis what was the question ?

photo of member not show in web portal, authentication is required in "viewimage.php"

@hregis
Copy link
Contributor Author

hregis commented Nov 10, 2025

@frederic34 i add a TODO... maybe add the photo in ECM table with a share field ?

@hregis hregis requested a review from eldy November 10, 2025 09:51
@frederic34
Copy link
Member

and if you use the share to create the link
image

@hregis
Copy link
Contributor Author

hregis commented Nov 10, 2025

@frederic34 Yes, that's what I thought, but as a result, we can no longer use "showphoto" in the "header" function of the "FormCardWebPortal" class.

// logo or photo
$form = new Form($this->db);
$html .= '<div class="inline-block floatleft valignmiddle">';
$html .= '<div class="floatleft inline-block valignmiddle divphotoref">';
$html .= $form->showphoto('memberphoto', $object, 0, 0, 0, 'photowithmargin photoref', 'small', 1, 0, 1);

@frederic34
Copy link
Member

@hregis #36205

@hregis hregis changed the title FIX member photo not deleted in documents directory FIX member photo and thirdparty logo not deleted in documents directory Nov 10, 2025
@hregis hregis marked this pull request as draft November 10, 2025 11:59
@hregis hregis marked this pull request as ready for review November 10, 2025 12:24
@hregis
Copy link
Contributor Author

hregis commented Nov 10, 2025

@eldy it's ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants