Skip to content

Added rvn-app.com branded site template - #1294

Open
revynmedia wants to merge 3 commits into
Domain-Connect:masterfrom
revynmedia:master
Open

Added rvn-app.com branded site template#1294
revynmedia wants to merge 3 commits into
Domain-Connect:masterfrom
revynmedia:master

Conversation

@revynmedia

Copy link
Copy Markdown

Description

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):

@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. no syncPubKeyDomain syncPubKeyDomain not set. Template is not secured. Test links missing No test links from Online Editor provided labels Jun 26, 2026
@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Linter OK

revynmedia.com.branded-site.json

Level Code Note
info DCTL1029 template does not have syncPubKeyDomain
info DCTL1038 APEXCNAME and REDIRxxx records are not widely supported

rvn-app.com.branded-site.json

Level Code Note
info DCTL1038 APEXCNAME and REDIRxxx records are not widely supported

Updated version number and modified CNAME records for various subdomains.
@github-actions

Copy link
Copy Markdown

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

Labels to add: Checklist of common problems not complete, PR description incomplete, Test links missing
Labels to remove: Forged editor links

PR description check FAILED:
  FAIL  'Type of change': no checkboxes are ticked
  FAIL  'How Has This Been Tested?': 3/3 checkboxes are not ticked
  FAIL  'Checklist of common problems': no checkboxes are ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: revynmedia.com.branded-site.json: no editor test link found (expected template id 'revynmedia.com.branded-site')
  FAIL  Template coverage: rvn-app.com.branded-site.json: no editor test link found (expected template id 'rvn-app.com.branded-site')

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions Bot added the Stale label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. no syncPubKeyDomain syncPubKeyDomain not set. Template is not secured. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Stale Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant