add Swivu, Swivu Site#1337
Open
ahabalikhan wants to merge 1 commit into
Open
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
pawel-kow
requested changes
Jul 8, 2026
| { | ||
| "type": "CNAME", | ||
| "host": "%acm_validation_host_0%", | ||
| "pointsTo": "%acm_validation_value_0%", |
Member
There was a problem hiding this comment.
Can the part acm-validations.aws. be fixed?
Author
There was a problem hiding this comment.
Thanks for the review, fixed.
PR Description Check PassedAll required sections are filled in correctly. Details |
80410d3 to
3c3b8c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Domain Connect template for Swivu custom-domain hosting (
providerId:swivu,serviceId:site).When a board owner connects a subdomain (e.g.
www.example.com) to a published Swivu site, this template creates:%acm_validation_host_0%→%acm_validation_value_0%.acm-validations.aws.(token values from AWS ACM, passed on apply)hostapply parameter +@record) →%cname_target%(Swivu custom-domain CDN hostname)Matches the apply URL built by swivu-server
CustomDomainService._build_domain_connect_url.Note: Staging/dev publishes the same template at
domaintemplate.dev.swivu.com; production usesdomaintemplate.swivu.com(syncPubKeyDomain).Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC) — N/A (no TXT records)@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR description — ACM validationpointsTouses%acm_validation_value_0%.acm-validations.aws.with the token-only variable; the.acm-validations.aws.suffix is fixed in the template (same pattern asbuckt.dev.acm-validation,kitkaton.com.storefront)hostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR description —%acm_validation_host_0%is bare because AWS ACM prescribes the validation record label token; the site domain suffix is supplied by the applyhost+domainparameters (hostRequired)hostfield to create a subdomain — use thehostparameter ormultiInstanceinstead — routing uses@withhostRequired; subdomain comes from applyhostparam%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC) — N/AOnline Editor test results
Editor test link(s):
Test swivu/site example.com/www
Subdomain test (
domain=example.com,host=www) produces:_abc123.www.example.comCNAME →_xyz789.acm-validations.aws.www.example.comCNAME →custom.swivu.site