Skip to content

add Swivu, Swivu Site#1337

Open
ahabalikhan wants to merge 1 commit into
Domain-Connect:masterfrom
Swivu:add-swivu-site-upstream
Open

add Swivu, Swivu Site#1337
ahabalikhan wants to merge 1 commit into
Domain-Connect:masterfrom
Swivu:add-swivu-site-upstream

Conversation

@ahabalikhan

@ahabalikhan ahabalikhan commented Jul 7, 2026

Copy link
Copy Markdown

Description

Add Domain Connect template for Swivu custom-domain hosting (providerId: swivu, serviceId: site).

When a board owner connects a subdomain (e.g. www.example.com) to a published Swivu site, this template creates:

  1. ACM validation CNAME%acm_validation_host_0%%acm_validation_value_0%.acm-validations.aws. (token values from AWS ACM, passed on apply)
  2. Routing CNAME — on the requested subdomain (host apply parameter + @ record) → %cname_target% (Swivu custom-domain CDN hostname)

Matches the apply URL built by swivu-server CustomDomainService._build_domain_connect_url.

Note: Staging/dev publishes the same template at domaintemplate.dev.swivu.com; production uses domaintemplate.swivu.com (syncPubKeyDomain).

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC) — N/A (no TXT records)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description — ACM validation pointsTo uses %acm_validation_value_0%.acm-validations.aws. with the token-only variable; the .acm-validations.aws. suffix is fixed in the template (same pattern as buckt.dev.acm-validation, kitkaton.com.storefront)
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description — %acm_validation_host_0% is bare because AWS ACM prescribes the validation record label token; the site domain suffix is supplied by the apply host + domain parameters (hostRequired)
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead — routing uses @ with hostRequired; subdomain comes from apply host param
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC) — N/A

Online Editor test results

Editor test link(s):

Test swivu/site example.com/www

Subdomain test (domain=example.com, host=www) produces:

  • _abc123.www.example.com CNAME → _xyz789.acm-validations.aws.
  • www.example.com CNAME → custom.swivu.site

@github-actions github-actions Bot added the hostRequired hostRequired is set label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Linter OK

swivu.site.json

Level Code Note

Comment thread swivu.site.json Outdated
{
"type": "CNAME",
"host": "%acm_validation_host_0%",
"pointsTo": "%acm_validation_value_0%",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the part acm-validations.aws. be fixed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, fixed.

@github-actions github-actions Bot added review issues Changes requested from PR review Test links missing No test links from Online Editor provided and removed Test links missing No test links from Online Editor provided labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@github-actions github-actions Bot added new review needed New commits arrived to PR after changes requested in the review and removed review issues Changes requested from PR review labels Jul 9, 2026
@ahabalikhan ahabalikhan force-pushed the add-swivu-site-upstream branch from 80410d3 to 3c3b8c3 Compare July 9, 2026 13:38
@ahabalikhan ahabalikhan requested a review from pawel-kow July 9, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hostRequired hostRequired is set new review needed New commits arrived to PR after changes requested in the review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants