fix: keep the user client config when switching to a direct connect endpoint - #14
Open
Dor-bl wants to merge 1 commit into
Open
fix: keep the user client config when switching to a direct connect endpoint#14Dor-bl wants to merge 1 commit into
Dor-bl wants to merge 1 commit into
Conversation
…ndpoint When the server decorates the new session response with the directConnect* capabilities, the client rebuilt its command executor out of the endpoint URL alone. That silently dropped every setting of the AppiumClientConfig given by the user, including the read timeout, the pool manager arguments, the proxy, the CA bundle and the authentication credentials, and downgraded the config instance to a plain selenium ClientConfig. The most visible consequence was that the documented way of configuring a read timeout had no effect on such sessions, so a hanging server call never timed out. Reuse a copy of the current configuration and only replace the endpoint it points to instead. Copying keeps the instance given by the user untouched. It also stops the deprecated remote_server_addr/keep_alive constructor arguments of RemoteConnection from being used. Closes appium#855 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PjZRpyoEfSCLjTx5ctzQmJ
Dor-bl
force-pushed
the
claude/upstream-issue-fix-50rwr8
branch
from
September 5, 2026 06:00
d486363 to
9bfcc07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server decorates the new session response with the directConnect*
capabilities, the client rebuilt its command executor out of the endpoint URL
alone. That silently dropped every setting of the AppiumClientConfig given by
the user, including the read timeout, the pool manager arguments, the proxy,
the CA bundle and the authentication credentials, and downgraded the config
instance to a plain selenium ClientConfig.
The most visible consequence was that the documented way of configuring a read
timeout had no effect on such sessions, so a hanging server call never timed
out. Reuse a copy of the current configuration and only replace the endpoint it
points to instead. Copying keeps the instance given by the user untouched.
It also stops the deprecated remote_server_addr/keep_alive constructor
arguments of RemoteConnection from being used.
Closes appium#855
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PjZRpyoEfSCLjTx5ctzQmJ