add c3q form, adjust tags and title#29
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughA new C3Q HIV questionnaire instrument is added at ChangesC3Q Form Definition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
lib/forms/C3Q/index.ts (1)
2-2: ⚡ Quick winConsider using Zod v4 API for new instruments.
New instruments should prefer the v4 API. Update the import to:
-import { z } from '/runtime/v1/zod@3.x'; +import { z } from '/runtime/v1/zod@3.x/v4';No code changes required in the validation schema itself.
As per coding guidelines: "New instruments should use the v4 API (/runtime/v1/zod@3.x/v4)."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/forms/C3Q/index.ts` at line 2, The import is using the Zod v3 path; update the module specifier to the v4 API per guideline by changing the import of z from '/runtime/v1/zod@3.x' to the v4 runtime path (use the v4 variant used across the repo) in lib/forms/C3Q/index.ts; no schema changes required—only update the import statement so the rest of the file (z usages) continues to work with Zod v4.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/forms/C3Q/index.ts`:
- Line 14: There is a French typo in the options list: change the string 'Un
peut' to the correct 'Un peu' (locate and update the entry containing "'Un
peut'" in lib/forms/C3Q/index.ts and replace it with "'Un peu'").
- Around line 210-213: internal.name is incorrectly set to
'STARKSTEIN_APATHY_SCALE' but should identify the C3Q instrument; update the
internal.name property in the form definition (the object containing
internal.name) to 'C3Q' so the instrument identity matches title/tags/PR intent
(search for internal.name in the C3Q form module to locate and change it).
---
Nitpick comments:
In `@lib/forms/C3Q/index.ts`:
- Line 2: The import is using the Zod v3 path; update the module specifier to
the v4 API per guideline by changing the import of z from '/runtime/v1/zod@3.x'
to the v4 runtime path (use the v4 variant used across the repo) in
lib/forms/C3Q/index.ts; no schema changes required—only update the import
statement so the rest of the file (z usages) continues to work with Zod v4.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0e9c2bd7-782f-4ecd-b51f-63b3b3d2cfeb
📒 Files selected for processing (1)
lib/forms/C3Q/index.ts
closes issue https://github.com/DouglasNeuroInformatics/CPP/issues/78
Moves the content of the starkstein apathy form into the c3q form.
form can be viewed here
Summary by CodeRabbit