Skip to content

fix: import ApiProperty from public entry instead of swagger dist sub…#75

Merged
joshunrau merged 4 commits into
mainfrom
devel
Jun 4, 2026
Merged

fix: import ApiProperty from public entry instead of swagger dist sub…#75
joshunrau merged 4 commits into
mainfrom
devel

Conversation

@joshunrau

@joshunrau joshunrau commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

@nestjs/swagger's exports field encapsulates dist/, so the deep import of
createApiPropertyDecorator failed under ESM resolution. ApiProperty is the
equivalent public API (calls the factory with overrideExisting=true).

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

Summary by CodeRabbit

  • Chores
    • Extended Node.js engine support to include versions 22.x and 24.x
    • Updated development dependencies for compatibility

joshunrau and others added 4 commits June 4, 2026 11:32
…path

@nestjs/swagger's exports field encapsulates dist/, so the deep import of
createApiPropertyDecorator failed under ESM resolution. ApiProperty is the
equivalent public API (calls the factory with overrideExisting=true).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@joshunrau joshunrau merged commit 79c7ef7 into main Jun 4, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0c5785fe-e355-458a-a1c4-bfb7e8c26307

📥 Commits

Reviewing files that changed from the base of the PR and between 542187b and ed8a1c2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .nvmrc
  • package.json
  • src/utils/validation.utils.ts

Walkthrough

Node.js version updated from LTS jod to krypton, engine constraint broadened to support 22.x and 24.x, development dependencies bumped to compatible versions, and Swagger decorator application simplified to use ApiProperty directly instead of a wrapper helper.

Changes

Node.js 24.x upgrade and Swagger refactoring

Layer / File(s) Summary
Node.js and dependency version updates
.nvmrc, package.json
Node.js LTS reference updated from lts/jod to lts/krypton; engine constraint expanded from 22.x to 22.x || 24.x; @types/node raised to 24.x and @douglasneuroinformatics/semantic-release bumped to ^0.2.2.
Swagger decorator simplification
src/utils/validation.utils.ts
Import updated to use ApiProperty directly; applySwaggerMetadata refactored to invoke ApiProperty(propertyMetadata) instead of createApiPropertyDecorator(propertyMetadata, true).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🚀 From jod to krypton we ascend,
Version 24 becomes a friend,
Node support expands its reach,
Swagger decorators simplified to teach,
Smooth upgrades with NestJS might. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ba5b897) to head (ed8a1c2).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines          704       704           
  Branches       118       118           
=========================================
  Hits           704       704           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 8.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant