tests(fix): isolate release fixtures from live smoke decisions

[Ducksss]

A live release exports its Desktop smoke decision into make check. The new waiver consequently reached ordinary GitHub-release fixtures, which correctly rejected their fixture notes as missing disclosure. Clear the inherited decision at the test boundary; individual waiver scenarios still set it explicitly.

Validated with DESKTOP_SMOKE_ATTESTATION=waived-by-maintainer bash test/release/github-test.sh and make lint. The live release stopped in read-only verification and made no tag or publication changes.

Summary by CodeRabbit

• Tests
  • Smoke test fixtures now run without inheriting the DESKTOP_SMOKE_ATTESTATION environment setting, ensuring results are controlled by each fixture.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1c9b82c8-ef16-40d9-a542-f959d63b9570

📥 Commits

Reviewing files that changed from the base of the PR and between f772389 and ecb0c43.

📒 Files selected for processing (1)

• test/release/github-test.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The release test script now clears DESKTOP_SMOKE_ATTESTATION before fixture execution. Smoke decisions therefore come from fixture configuration instead of the inherited environment.

Changes

Release test isolation

Layer / File(s)	Summary
Clear smoke attestation before fixtures test/release/github-test.sh	The script unsets DESKTOP_SMOKE_ATTESTATION before running fixtures.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ecb0c

Release fixtures now ignore inherited desktop smoke-waiver state while preserving explicit fixture waivers. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: isolating release fixtures from inherited live smoke decisions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch PinZheng/release-test-isolation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}