Draft
Conversation
Contributor
Author
|
Although we don't have the symlinks yet, I can actually already test this in the container - it will just create the symlinks in What I did: Works as intended. After implementing the variant symlinks, we should retest, try to use the |
Contributor
|
Tested in the container using EESSI 2025.06 and without having configured the variant symlinks: With the variant symlink reconfigured as Wiping that dir and doing it again using Also checked the symlinks, and the pointed to the expected locations. |
bedroge
reviewed
Feb 17, 2026
| msg="${msg} the EESSI_NVIDIA_OVERRIDE_DEFAULT variant symlink in your local CVMFS configuration to point to" | ||
| msg="${msg} writeable location. This will change the target of symlink ${target1}.\n" | ||
| msg="${msg}If you want to symlink the drivers only for this version of EESSI (${EESSI_VERSION}), please define" | ||
| msg="${msg} the EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE variant symlink in your local CVMFS configuration to point to" |
Contributor
There was a problem hiding this comment.
Suggested change
| msg="${msg} the EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE variant symlink in your local CVMFS configuration to point to" | |
| msg="${msg} the EESSI_${EESSI_VERSION//./}_NVIDIA_OVERRIDE variant symlink in your local CVMFS configuration to point to" |
bedroge
reviewed
Feb 17, 2026
| fatal_error "${msg}" | ||
| fi | ||
| else | ||
| msg="$target1 does not seem to be a CVMFS variant symlink, suggesting that EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE" |
Contributor
There was a problem hiding this comment.
Suggested change
| msg="$target1 does not seem to be a CVMFS variant symlink, suggesting that EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE" | |
| msg="$target1 does not seem to be a CVMFS variant symlink, suggesting that EESSI_${EESSI_VERSION//./}_NVIDIA_OVERRIDE" |
bedroge
reviewed
Feb 17, 2026
| nvidia_trusted_dir="${EESSI_EPREFIX}/lib/nvidia" | ||
| if [[ -L "$nvidia_trusted_dir" ]]; then | ||
| target1=$(readlink "$nvidia_trusted_dir") | ||
| log_verbose "$nvidia_trusted_dir is a CVMFS variant symlink (EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE) currently pointing to $target1" |
Contributor
There was a problem hiding this comment.
Suggested change
| log_verbose "$nvidia_trusted_dir is a CVMFS variant symlink (EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE) currently pointing to $target1" | |
| log_verbose "$nvidia_trusted_dir is a CVMFS variant symlink (EESSI_${EESSI_VERSION//./}_NVIDIA_OVERRIDE) currently pointing to $target1" |
bedroge
reviewed
Feb 17, 2026
| log_verbose "${msg}" | ||
|
|
||
| # Check if target2 isn't /dev/null (the default target of the EESSI_NVIDIA_OVERRIDE_DEFAULT variant symlink) | ||
| # If it is, suggest setting EESSI_NVIDIA_OVERRIDE_DEFAULT or EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE |
Contributor
There was a problem hiding this comment.
Suggested change
| # If it is, suggest setting EESSI_NVIDIA_OVERRIDE_DEFAULT or EESSI_${ESSSI_VERSION//./}_NVIDIA_OVERRIDE | |
| # If it is, suggest setting EESSI_NVIDIA_OVERRIDE_DEFAULT or EESSI_${EESSI_VERSION//./}_NVIDIA_OVERRIDE |
bedroge
reviewed
Feb 17, 2026
| # Do some checks on existence of links and that we don't end up at /dev/null (the default), so we can print some informative information | ||
| # One downside is that we can't explicitely check if something is a variant symlink, so we'll just assume that if it's a link AND it | ||
| # lives in our CVMFS repository, it must be a variant symlink | ||
| nvidia_trusted_dir="${EESSI_EPREFIX}/lib/nvidia" |
Contributor
There was a problem hiding this comment.
Does this mean that the script will no longer work for 2023.06?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll need the following variant symlinks to be in place before this script can work as intended:
And then:
This can then be quite easily tested from within the container:
This should error out stating that the variant symlink resolves to
/dev/null. Then, you can change/etc/cvmfs/default.localto set e.g.EESSI_NVIDIA_OVERRIDE_DEFAULT(e.g. to/opt/eessi/nvidia) and run the linking script again - this should the install the symlinks.