Skip to content

fix typo in eessi_container.sh fixing the script when http_proxy is set#161

Merged
bedroge merged 1 commit intoEESSI:mainfrom
TopRichard:Fix-typo-eessi_container.sh
Feb 16, 2026
Merged

fix typo in eessi_container.sh fixing the script when http_proxy is set#161
bedroge merged 1 commit intoEESSI:mainfrom
TopRichard:Fix-typo-eessi_container.sh

Conversation

@TopRichard
Copy link
Collaborator

@TopRichard TopRichard commented Feb 16, 2026

When http_proxy is set, the condition [[ -z ${BIND_PATH} ]] evaluates true and the code replaces the entire BIND_PATHS with only the newly added mapping for default.local

@TopRichard TopRichard added the bug Something isn't working label Feb 16, 2026
@TopRichard TopRichard changed the title fix typo in eessi_container.sh when http_proxy is set fix typo in eessi_container.sh fixing the script when http_proxy is set Feb 16, 2026
trz42
trz42 previously approved these changes Feb 16, 2026
Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@trz42
Copy link
Contributor

trz42 commented Feb 16, 2026

Change itself looks good, but many actions failed. Before merging it might be good to figure out why these are failing.

@bedroge bedroge merged commit 29f2afb into EESSI:main Feb 16, 2026
108 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants