use nodes option and factor out common required config#310

Open

smoors wants to merge 10 commits intoEESSI:mainfrom

smoors:nodes_option

Collaborator

smoors commented Dec 21, 2025 •

edited

Loading

fixes #304

Samuel Moors added 3 commits

December 21, 2025 16:14


          use nodes option and factor out common slurm config

e8e78cf


          completely overwrite resources for now to avoid issues

3e2ab97


          factor out more common stuff

9d0a926

smoors changed the title ~~use nodes option and factor out common slurm config~~ use nodes option and factor out common required config


          also update github_actions.py

af76af6

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

Samuel Moors added 2 commits

December 25, 2025 20:23


          Merge branch 'main' into nodes_option

844fa75


          allow other sched_options; notify when changing site config

aedce55

casparvl self-requested a review

January 21, 2026 14:09

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Show resolved Hide resolved

casparvl reviewed

View reviewed changes

eessi/testsuite/common_config.py Outdated Show resolved Hide resolved

casparvl requested changes

View reviewed changes

Collaborator

casparvl left a comment

I think the indentation on the section that overwrites the partition resources is wrong.

Some logic could be more explicit, but that's a matter of taste I guess - I've made some suggestions.

Samuel Moors added 4 commits

February 11, 2026 19:59


          restrict setuptools to <=81.0.0

a8fc81d


          merge main

64d6537


          make suggested changes

66e83c4


          fix for set_memory argument

Collaborator Author

smoors commented Feb 11, 2026

@casparvl all your suggestions done (+ set_memory fix)

smoors requested a review from casparvl

February 11, 2026 19:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet