This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Add command line option --snapshot-to-json 📦#11058
Open
heifner wants to merge 2 commits intodevelop-boxedfrom
Open
Add command line option --snapshot-to-json 📦#11058heifner wants to merge 2 commits intodevelop-boxedfrom
heifner wants to merge 2 commits intodevelop-boxedfrom
Conversation
heifner
changed the title
|
I wonder how long this takes to run on a wax snapshot? They're huge. I can't imagine the json file. |
Contributor
Author
1hr to read WAX 21GB binary snapshot, 37 minutes to write the 59 GB JSON on my old mac. |
linhuang-blockone
approved these changes
Feb 7, 2022
dimas1185
reviewed
Mar 17, 2022
|
|
||
| std::optional<chain_id_type> chain_id; | ||
| if( options.count("snapshot-to-json") ) { | ||
| my->snapshot_path = options.at( "snapshot-to-json" ).as<bfs::path>(); |
Contributor
There was a problem hiding this comment.
please move that code to the separate method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
--snapshot-to-jsonwhich reads given snapshot.bin and generates a JSON equivalent file.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions