[Formal][PropertyAnnotation] Annotating IOG-based invariants#855
Open
Basmet0 wants to merge 7 commits intoEPFL-LAP:mainfrom
Open
[Formal][PropertyAnnotation] Annotating IOG-based invariants#855Basmet0 wants to merge 7 commits intoEPFL-LAP:mainfrom
Basmet0 wants to merge 7 commits intoEPFL-LAP:mainfrom
Conversation
Jiahui17
reviewed
Apr 16, 2026
| void step() { | ||
| if (partials.empty()) | ||
| return; | ||
| auto checkpoint = partials.back(); |
Member
There was a problem hiding this comment.
Maybe std::move is more efficient
auto checkpoint = std::move(partials.back());
partials.pop_back();
| llvm::DenseSet<mlir::Value> illegals; | ||
| // Is the partial IOG still following the rules? Note that DONE does not | ||
| // actually mean done, as the `unhandled` stack should also be empty. | ||
| enum PROGRESS { ILLEGAL, PARTIAL, DONE }; |
Member
There was a problem hiding this comment.
enum Status {...}
// Is the partial IOG still following the rules? Note that DONE does not
// actually mean done, as theunhandledstack should also be empty.
I still don't get the difference between DONE and ACTUALLY_DONE?
| } | ||
| }; | ||
|
|
||
| struct IOGFinderCheckpoint { |
Member
There was a problem hiding this comment.
Why not do something like
struct IOGCandidate {
Operation *entry;
std::vector<Operation *> units;
std::vector<Value> channels;
DenseSet<Value> illegalChannels;
// What you called "unhandled."
std::vector<Value> bfsQueue;
IOG getIOG() const {
return IOG{this->units, this->channels, this->entry};
}
};
| illegals.insert(channel); | ||
| } | ||
|
|
||
| Operation *getNextOp() { |
Member
There was a problem hiding this comment.
std::optional<Operation *> ...
Comment on lines
+381
to
+384
| // Handle the `endOp` if it has not yet been inserted into the IOG | ||
| if (!partial.contains(endOp)) { | ||
| return endOp; | ||
| } |
Member
There was a problem hiding this comment.
I think this candidate class should be constructed from an endOp (so partial already contains the endOp to begin with
Comment on lines
+407
to
+413
| // To fully handle a channel, both the operation before and after have to be | ||
| // handled | ||
| Operation *before = channel.getDefiningOp(); | ||
| if (before && !partial.contains(before)) { | ||
| partial.units.insert(before); | ||
| return before; | ||
| } |
Member
There was a problem hiding this comment.
It looks quite messy that both getNextOp and step are taking care of both sides of a channel. Is it possible that we only handle the value owner here?
| enum PROGRESS { ILLEGAL, PARTIAL, DONE }; | ||
| PROGRESS progress = PARTIAL; | ||
| Operation *endOp; | ||
| std::vector<mlir::Value> entries; |
Member
There was a problem hiding this comment.
this can be a const reference to avoid copying it everytime we create a new one
also can be unordered (DenseMap) so we can check if(entries.count(...))
Comment on lines
+437
to
+453
| // This function takes a checkpoint and a list of channels. For each channel | ||
| // c, it pushes the IOG where *only* channel c is taken, and all the rest are | ||
| // illegal. Used for forks (which only allow exactly one of its outputs) and | ||
| // join operations (which only allow exactly one of its inputs) | ||
| template <typename T> | ||
| void followSingle(const IOGFinderCheckpoint &checkpoint, T options) { | ||
| for (mlir::Value channel : options) { | ||
| IOGFinderCheckpoint goHere = checkpoint; | ||
| goHere.follow(channel); | ||
| for (mlir::Value other : options) { | ||
| if (channel == other) | ||
| continue; | ||
| goHere.makeIllegal(other); | ||
| } | ||
| partials.push_back(goHere); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
there is a thing called static method that returns a new instance of ..
added 6 commits
April 16, 2026 15:26
… active fork in between
…t the first slot) edge case: As the MC is not part of the IOG, tokens "hidden" within MC are not accounted for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.