Skip to content

Ensured that new_k_max is at least 1 in resize of QP ASM factor.hpp - #3458

Merged
jajhall merged 7 commits into
latestfrom
fix-3453
Oct 23, 2026
Merged

jajhall merged 7 commits into
latestfrom
fix-3453

Conversation

@jajhall

@jajhall jajhall commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Description

In resize of QP ASM factor.hpp, if new_k_max is ever zero, then current_k_max = 0, so when 2*current_k_max is passed into resize from expand, new_k_max is still zero. Observed in #3453, but could not reproduce. No harm in ensuring that the value used for new_k_max is at least 1.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3453

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.13%. Comparing base (28117fb) to head (63e0f00).
⚠️ Report is 6 commits behind head on latest.

Files with missing lines Patch % Lines
highs/lp_data/HighsInfo.cpp 50.00% 1 Missing ⚠️
highs/lp_data/HighsInfo.h 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3458      +/-   ##
==========================================
- Coverage   75.13%   75.13%   -0.01%     
==========================================
  Files         460      460              
  Lines      112175   112194      +19     
  Branches    17787    17788       +1     
==========================================
+ Hits        84287    84298      +11     
- Misses      27606    27614       +8     
  Partials      282      282              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall
jajhall marked this pull request as draft October 22, 2026 21:23
@jajhall
jajhall marked this pull request as ready for review October 23, 2026 07:16
@jajhall

jajhall commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

This now incorporates the better fix-rowless-qp, so all the CI failures inherited from latest disappear

@jajhall
jajhall merged commit b2a51d3 into latest Oct 23, 2026
571 checks passed
@jajhall
jajhall deleted the fix-3453 branch October 23, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants