[Yanyu000]

Description

Checklist

• I have read the contributing guidelines
• This PR targets the latest branch
• Tests are passing
• Documentation was updated where relevant
• This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3467

[jajhall]

The failing CI tests are because latest + fix-3467-hipdlp-maximize has two issue-3459 unit tests, and this stops bin/unit_tests from running. It's partly my fault because I moved my original issue-3459 unit test from TestLpSolvers.cpp to TestCrossover.cpp (and then developed on my fix-3459 branch that was merged into latest and hour ago.

So, please pull latest and merge it into fix-3467-hipdlp-maximize, then delete the old issue-3459 unit test from TestLpSolvers.cpp.

Thanks for excluding free rows

There are a few other points I'll discuss with you tomorrow.

[codecov]

Codecov Report

❌ Patch coverage is 98.55072% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.23%. Comparing base (4dedd8d) to head (6792299).
⚠️ Report is 4 commits behind head on latest.

Files with missing lines	Patch %	Lines
highs/pdlp/hipdlp/pdhg.cc	91.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           latest    #3469      +/-   ##
==========================================
+ Coverage   75.19%   75.23%   +0.04%     
==========================================
  Files         460      460              
  Lines      112377   112501     +124     
  Branches    17822    17834      +12     
==========================================
+ Hits        84504    84643     +139     
+ Misses      27591    27576      -15     
  Partials      282      282              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jajhall]

Very nice, and good that you've thought of the "all rows free" case.

I've made some changes

• TestPdlpHi.cpp was only good as a name because it came immediately after TestPdlp.cpp alphabetically. However, it's testing HiPdlp, so I've changed the name
• I've added TestPdlp.cpp to the Bazel build and Meson check. Although this means that HiPDLP runs on a CPU, the instances are solved very easily, so there's no real increase in the testing time. Please can you confirm that this is all OK @galabovaa
• A few calls to the (deprecated) method resetGlobalScheduler have crept in via new tests - not just yours - so I've changed these to resetThreadScheduler