Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3480 +/- ##
==========================================
+ Coverage 75.24% 75.32% +0.07%
==========================================
Files 460 460
Lines 112567 112769 +202
Branches 17836 17856 +20
==========================================
+ Hits 84697 84938 +241
+ Misses 27588 27543 -45
- Partials 282 288 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Looks fine to me. |
Contributor
Author
|
@filikat something like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For scipy build:
scipy/scipy#26440 (comment)
METIS interface move to a single HiGHS-owned header, extern/HighsMetis.h, outside extern/metis so it survives SciPy's trimming. metis/metis.h and HighsExtrasExternalDeps.h both include it.
Tested (Windows, HIPO=ON, openblas[threads]): MSVC and clang-cl both build cleanly. With MSVC, HiPO results and runtimes are unchanged.
valgrind failure is unrelated: ParallelSchedulerIsPerThread uses a 1s timeout in waitFor(), which is too short under valgrind's slowdown. Valgrind found no memory errors, and other branches pass. Suggest raising the timeout to around 30s.
Valgrind runs all threads one at a time on a single core. While thread A spins in waitFor it competes with thread B, which still has to start its scheduler threads and do the parallel sum. A busy CI runner could exceed 1s.
waitFor returns as soon as the flag is set, so in a passing run the timeout never adds any time. It only matters if the threads genuinely deadlock, and then the only effect is that the test fails after 30s instead of 3s.
Checklist
latestbranch