Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3485 +/- ##
==========================================
- Coverage 75.24% 75.22% -0.03%
==========================================
Files 460 460
Lines 112567 112523 -44
Branches 17836 17827 -9
==========================================
- Hits 84697 84641 -56
- Misses 27588 27600 +12
Partials 282 282 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
filikat
marked this pull request as ready for review
October 28, 2026 17:32
jajhall
reviewed
Oct 28, 2026
| assert(static_cast<HighsInt>(start_.size()) >= num_col_ + 1); | ||
| assert(static_cast<HighsInt>(index_.size()) >= numNz()); | ||
| assert(static_cast<HighsInt>(value_.size()) >= numNz()); | ||
| } |
Member
There was a problem hiding this comment.
Can these be == rather than >=, as not keeping sizes tight has caused segfault in presolve (for example)
jajhall
reviewed
Oct 28, 2026
| assert(numNz() == num_nz); | ||
| assert(static_cast<HighsInt>(start_.size()) >= num_row_ + 1); | ||
| assert(static_cast<HighsInt>(index_.size()) >= numNz()); | ||
| assert(static_cast<HighsInt>(value_.size()) >= numNz()); |
Member
There was a problem hiding this comment.
Can these be == rather than >=, as not keeping sizes tight has caused segfault in presolve (for example)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
ensureRowwiseandensureColwisemake an internal copy of the matrix and then build the correct format in the original storage of the matrix. We can avoid the copy by building the correct format in a temporary object and move assigning to the original matrix.*this = oppositeFormat()does this and does not need an explicitstd::move, since the result ofoppositeFormat()is a temporary. However, it does need the move assignment operation to be declared, otherwise it would fall back to a deep copy. This is why the special operations ofHighsSparseMatrixare explicitly defaulted, so that if someone defines a custom copy operation, the move operations do not silently vanish.Checklist
latestbranch