Repository navigation
Prefer ROCm headers of the HIP compiler over a system HIP install - #3486
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3486 +/- ##
==========================================
- Coverage 75.32% 75.31% -0.01%
==========================================
Files 460 460
Lines 112769 112769
Branches 17856 17856
==========================================
- Hits 84938 84934 -4
- Misses 27543 27547 +4
Partials 288 288 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you, @amontoison |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was testing quickly
HiGHSthis afternoon on a recent MI350 GPU with a non-standard installation and I neededto pass a specific compilation flag.
This PR makes the detection of HIP headers more robust.
Checklist
latestbranch