Open
Conversation
verifying case-insensitive matches for string arguments. Tests assert that the delegate XMLConfiguration receive the expected calls.
Created a private constructor in implementation to prevent utility class instances. Moved test-scope key format into class instance. Updated uses. Moved test-scoped time format into class instances. Updated uses.
Adding case verifying exception on unknown parameter type.
Adding validation to assert the data type of the returned Objects.
Removing useless method override.
Adding tests for the current behavior of the WAF Action classes.
Doing basic testing for some coverage. Nothing too verbose; only testing the content specified in each of the tag subclasses.
jeremiahjstacey
commented
Nov 1, 2025
|
|
||
| public boolean failedRule() { | ||
| return this.failed; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This method duplicates the super class' implementation. No point in it.
Collaborator
Author
|
I think this bumps coverage ~.2% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got bored and thought I'd pick out some low-hanging classes for a couple more tests.