chore(backend): consolidate to a single npm lockfile and remove the dead src/quest module - #2372
Merged
RUKAYAT-CODER merged 1 commit intoSep 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 (partial): consolidation — safe wins
Two low-risk consolidation changes, validated by CI.
1. Single backend lockfile (npm)
CI installs the backend with
npm ci(seebackend-ci,backend-lint,backend-integration), so npm/package-lock.jsonis the real standard. This removes the stray, trackedbun.lock. (pnpm-lock.yamlis already gitignored/untracked, so nothing to remove there.) The TypeORM migration npm-scripts still invoke Bun; that is unchanged and independent of the lockfile.2. Remove the dead
src/quest/moduleThe repo had three quest locations. Only
src/modules/quests/is wired (app.module.ts→QuestsModule, andsrc/database/data-source.tsuses itsQuestentity).src/quest/(this deletion) had zero importers anywhere and was not registered in any module — a genuine orphan duplicate. Entities are loaded explicitly indata-source.ts(no glob), so removing it cannot affect entity metadata.Explicitly NOT touched (needs a real refactor)
src/quests/(top-level) is not dead — itsQuestentity is imported by auth, jobs, submissions, and users — and it appears to be a secondQuestentity distinct fromsrc/modules/quests/entities/quest.entity.ts(the one the data source registers). Unifying those two is a genuine entity-consolidation refactor with real behavior risk; it should be done with a local build + migration review, so it is intentionally left for a dedicated follow-up rather than bundled here.Validation
I could not build locally (no toolchain), so I relied on static analysis (import graph + explicit entity loading) and am using CI to validate this removal. If backend CI goes red, the
src/quest/deletion should be reverted.