-
-
Notifications
You must be signed in to change notification settings - Fork 30
Handle NotFoundError during SD card erase #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pfeerick <[email protected]>
|
@copilot I beleive the NotFoundError issue is actually cross-platform, not macOS specific. Update the code and PR accordingly. |
Co-authored-by: pfeerick <[email protected]>
Updated in commit a26a64b. Changed the code comment from "Some weird macos folder or file already deleted" to "Handle stale file system handles or file already deleted" to reflect that this is a cross-platform issue. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 44.40% 44.39% -0.01%
==========================================
Files 108 108
Lines 12671 12673 +2
Branches 594 594
==========================================
Hits 5626 5626
- Misses 7037 7039 +2
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying buddy with
|
| Latest commit: |
4ce1774
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89364241.buddy-7a6.pages.dev |
| Branch Preview URL: | https://head.buddy-7a6.pages.dev |
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
|
@copilot Your thoughts on the check results? |
The CI test-types check is failing due to TypeScript errors in the new test case. The test is accessing |
Co-authored-by: pfeerick <[email protected]>
pfeerick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested preview on both Windows and macOS machines against four different handsets... now seems to be working correctly and don't hang at the end.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.