Add opensearch #31
Open
Add opensearch #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
reviewed
May 3, 2024
oerc0122
reviewed
May 3, 2024
oerc0122
requested changes
May 3, 2024
abcd/__init__.py
Outdated
|
|
||
| db = r.path.split('/')[1] if r.path else None | ||
| db = db if db else 'abcd' | ||
| db = r.path.split("/")[1] if r.path else None |
Collaborator
There was a problem hiding this comment.
I know this was there before but does this want to be a pathlib.Path instead?
Not sure if this is necessarily safe just taking the first element, but then again, I'm not 100% what "path" is a path to or contains.
It will also fail if r.path doesn't contain "/", e.g. winpath with "\"
abcd/__init__.py
Outdated
| db = r.path.split('/')[1] if r.path else None | ||
| db = db if db else 'abcd' | ||
| db = r.path.split("/")[1] if r.path else None | ||
| db = db if db else "abcd" |
Collaborator
There was a problem hiding this comment.
This seems unnecessary given it's just been assigned to None above, would
db = pth if r.path and (pth := r.path.split("/")[1]) else "abcd"be clearer? Not sure.
N.B. Python 3.8+
oerc0122
reviewed
Jun 11, 2024
ElliottKasoar
force-pushed
the
add_opensearch
branch
from
01e7a5f to
f17f950
Compare
ElliottKasoar
commented
Jun 11, 2024
ElliottKasoar
force-pushed
the
add_opensearch
branch
18 times, most recently
from
8e4036d to
0e30256
Compare
Co-authored-by: Jacob Wilkins <[email protected]>
Co-authored-by: Jacob Wilkins <[email protected]>
Co-authored-by: Jacob Wilkins <[email protected]>
Co-authored-by: Jacob Wilkins <[email protected]>
ElliottKasoar
force-pushed
the
add_opensearch
branch
from
03212eb to
39086be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.