Filter block entities by version support in ChunkDataPacket#228
Open
pingwiniu wants to merge 1 commit intoElytrium:masterfrom
Open
Filter block entities by version support in ChunkDataPacket#228pingwiniu wants to merge 1 commit intoElytrium:masterfrom
pingwiniu wants to merge 1 commit intoElytrium:masterfrom
Conversation
Block entities are now filtered to include only those supported by the current protocol version before being written to the buffer. This prevents unsupported block entities from being sent to clients on older versions. (I encountered this issue while trying to paste a schematica file on my server)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block entities are now filtered to include only those supported by the current protocol version before being written to the buffer. This prevents unsupported block entities from being sent to clients on older versions, which previously caused a NullPointerException.