Initial lab-internal Nocturne version#1
Merged
daphne-cornelisse merged 43 commits intodevelopfrom Oct 6, 2023
Merged
Conversation
daphne-cornelisse
force-pushed
the
feature/nocturne_fork_cleanup
branch
3 times, most recently
from
b3545dc to
a49472f
Compare
daphne-cornelisse
force-pushed
the
feature/nocturne_fork_cleanup
branch
from
a49472f to
4f21f93
Compare
…/nocturne into feature/nocturne_fork_cleanup
…figs/env_config.yml
…dded Python box to main group of dependencies
…/nocturne into feature/nocturne_fork_cleanup
…/nocturne into feature/nocturne_fork_cleanup
1. Added pydocstyle back into pre-commit
2. Moved WandB and tensorboard to research dependencies in pyproject.toml
3. Updated data paths for notebooks: (1) all data paths are now relative to the base of the project and (2) changing working directory in notebook to go to the base of the project
4. Updated number of tries for finding a controllable vehicle in base_env.py
…e part of docs branch
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
| class CMakeExtension(Extension): | ||
| class CMakeExtension(Pybind11Extension): |
| "<figure>\n", | ||
| "<center>\n", | ||
| "<img src='https://drive.google.com/uc?id=1fG43NvPCzaimmW99asRdB73qY-F4u-q0' width='700'/>\n", | ||
| "<figcaption>To investigate coordination under partial observability, agents in Nocturne can only see an obstructed view of their environment. In this simplified traffic scene, we construct the state for the red ego driver. Note that Nocturne assumes that stop signs can be viewed, even if they are behind another driver. </figcaption></center>\n", |
There was a problem hiding this comment.
There's a figure here that doesn't load for me
eugenevinitsky
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request merges the
nocturne_fork_cleanupbranch intodevelop. Thenocturne_fork_cleanupbranch contains several changes that clean up the codebase and remove unused code. The resulting repository is the version that should be used internally in the EMERGE lab for further development of Nocturne.Changes Made
The following changes were made in the
nocturne_fork_cleanupbranch:algosdirectoryexamplesdirectoryalgosandexamplespoetry:poetryfor and to simplify package managementalgosandexamples)pre-commit:pre-commitblack,flake8,isort,pydocstyle, andpylint)Publish package-> Moved forwardPublish package to PyPISupport for multiple Python versions-> Moved forwardUpdate legacy Github workflows-> Moved forwardFix notebook editable package bug-> Moved forwardRelated Issues
This pull request resolves the no outstanding issues.
Review checklist
TBA