Governance - delegate to Drep #4443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...oroi-extension/app/UI/features/governace/useCases/GovernanceStatusRevamp/DrepOptionsCard.tsx
Outdated
Show resolved
Hide resolved
packages/yoroi-extension/app/UI/features/governace/common/hooks/useGovernanceStatusState.tsx
Show resolved
Hide resolved
...es/yoroi-extension/app/UI/features/governace/useCases/GovernanceStatusRevamp/DRepOptions.tsx
Outdated
Show resolved
Hide resolved
...roi-extension/app/UI/features/transaction-review/useCases/ChooseDrepId/ChooseOtherDrepId.tsx
Show resolved
Hide resolved
...tension/app/UI/features/governace/useCases/GovernanceStatusRevamp/GovernanceStatusRevamp.tsx
Outdated
Show resolved
Hide resolved
...ion/app/UI/features/governace/useCases/GovernanceStatusRevamp/GovernanceStatusRevampCard.tsx
Outdated
Show resolved
Hide resolved
...ion/app/UI/features/governace/useCases/GovernanceStatusRevamp/GovernanceStatusRevampCard.tsx
Outdated
Show resolved
Hide resolved
...ion/app/UI/features/governace/useCases/GovernanceStatusRevamp/GovernanceStatusRevampCard.tsx
Outdated
Show resolved
Hide resolved
| const isDelegatingToYoroiDrep = isDelegated && drepID === YOROI_DREP_ID; | ||
| const isDelegationToOtherDrep = isDelegated && drepID !== YOROI_DREP_ID; | ||
| const isAbstain = drepID === null || governanceStatus.status === DREP_ALWAYS_ABSTAIN; | ||
| const isNoConfidence = drepID === null || governanceStatus.status === DREP_ALWAYS_NO_CONFIDENCE; |
There was a problem hiding this comment.
Bug: Null check on variable that can never be null
The isAbstain and isNoConfidence flags use drepID === null in their conditions. However, drepID is always assigned a value (falling back to YOROI_DREP_ID), so it can never be null. This prevents correctly identifying "Abstain" or "No Confidence" delegations when the DRep ID is truly null.
Nebyt
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces a full governance delegation flow (Yoroi/other DReps, abstain/no-confidence) with a revamped UI and integrated transaction review, plus supporting hooks, context, and i18n updates.
GovernanceStatusRevamp,DRepOptions,DrepOptionsCard, andNotAllowedInGovernance.ChooseOtherDrepIdflow and integrates it intoReviewTxManager(modalView: 'chooseOtherDrepId').useGovernanceDelegationToYoroiDrep: creates/signs delegation txs, opens review modal, handles errors (e.g., insufficient funds).useGovernanceStatusState: maps backend status toGOVERNANCE_STATUSand detects pending delegation txs.useIsGovernanceAllowed: checks ADA balance/participation and testnet.GovernanceContextProvider: exposesisTestnet; fetches and normalizes on-chain governance status.constants.ts: addsFIND_DREPS_LINK(_TESTNET),GOVERNANCE_STATUSenum.en-US.jsonaccordingly.YoroiLogoaccepts dynamicwidth/height.truncateFormatterhelper (TS) and export in JS formatters; used in cards.useStringsimport paths undercommon/hooks.Written by Cursor Bugbot for commit eb147c5. This will update automatically on new commits. Configure here.