Skip to content

Refactor: Separate OAuth logic from MCP Server#7

Open
rnovatorov wants to merge 2 commits intomainfrom
refactor-oauth-logic-13770356607907446481
Open

Refactor: Separate OAuth logic from MCP Server#7
rnovatorov wants to merge 2 commits intomainfrom
refactor-oauth-logic-13770356607907446481

Conversation

@rnovatorov
Copy link
Member

Moved OAuth and authentication logic from src/enapter_mcp_server/mcp/server.py to a new module src/enapter_mcp_server/mcp/auth.py.
Introduced AuthProvider, HeaderAuthProvider, and OAuthProxyAuthProvider classes to handle authentication strategies.
Updated Server class to use AuthProvider for configuring FastMCP authentication and retrieving Enapter API authentication.
This change improves modularity and testability by decoupling authentication logic from the main server implementation.


PR created automatically by Jules for task 13770356607907446481 started by @rnovatorov

Moved OAuth and authentication logic from `src/enapter_mcp_server/mcp/server.py` to a new module `src/enapter_mcp_server/mcp/auth.py`.
Introduced `AuthProvider`, `HeaderAuthProvider`, and `OAuthProxyAuthProvider` classes to handle authentication strategies.
Updated `Server` class to use `AuthProvider` for configuring FastMCP authentication and retrieving Enapter API authentication.
This change improves modularity and testability by decoupling authentication logic from the main server implementation.

Co-authored-by: rnovatorov <20299819+rnovatorov@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Moved OAuth and authentication logic from `src/enapter_mcp_server/mcp/server.py` to a new module `src/enapter_mcp_server/mcp/auth.py`.
Introduced `AuthProvider`, `HeaderAuthProvider`, and `OAuthProxyAuthProvider` classes to handle authentication strategies.
Updated `Server` class to use `AuthProvider` for configuring FastMCP authentication and retrieving Enapter API authentication.
Fixed isort import ordering in `src/enapter_mcp_server/mcp/server.py`.

Co-authored-by: rnovatorov <20299819+rnovatorov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant