Repository navigation
Use production leadership timing in Accord test fixtures - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Accord integration fixture used a 500 ms leadership lease. On a busy CI runner, a short scheduling pause could expire that lease and correctly trigger Accord 0.6.1’s fatal-leadership shutdown, making authority reuse and resource registration fail. An 800 ms pause reproduced the installer SERVICE_HOME failure.
Use the production five-second leadership window in the fixture and derive the coordinator crash-recovery wait from it. A regression test pauses only the disposable coordinator and verifies that authority reuse still succeeds without service installation.
Validation: all 20 Accord installation, scheduling, workload CLI and runner tests passed; focused ESLint, Prettier, and diff checks passed. Production timing and vendored source are unchanged.