Repository navigation
Describe how private_paths actually matches - #19
Open
kridaydave wants to merge 1 commit into
Open
kridaydave wants to merge 1 commit into
kridaydave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visibility.tomlclaimed its patterns were "matched by substring against touched paths". That is not whatVisibilityPolicy::path_is_privatedoes (src/visibility.rs:120-151), and the false reading is load-bearing: it is the reading that would make the shipped.pementry catch a certificate.Measured against the real function with this repo's own
private_paths:The matcher does whole-segment matching.
.pemmatches a file literally named.pem, and nothing else.Comment-only. The docket output is byte-identical before and after, so this carries no behavior delta.
Not shipped
.pemstaying inert is a bug on the export path (store.rs:1130andstore.rs:1830both gate onpath_is_private), andcerts/server.pemis published uncloaked. Two ways to close it, both a call the maintainer should make:*.pem. One line, no code, uses the wildcard the matcher already supports..pemmeans "any file ending in.pem". More useful generally, but it changes the semantics of every existing policy file, and the export security boundary is not a place to make that call unattended.I did not take either. Written up rather than shipped, per the boundary rule.