Skip to content

Use new ShardRange interface + impl #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbordersTwitch wants to merge 1 commit into
base: snapshot/typo/v5
Choose a base branch
from
Open

Use new ShardRange interface + impl #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eppo/src/main/java/cloud/eppo/android/dto/adapters/FlagConfigResponseDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import cloud.eppo.api.dto.TargetingRule;
import cloud.eppo.api.dto.Variation;
import cloud.eppo.api.dto.VariationType;
import cloud.eppo.model.ShardRange;
import cloud.eppo.api.dto.ShardRange;
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.databind.DeserializationContext;
import com.fasterxml.jackson.databind.JsonNode;
Expand Down Expand Up @@ -219,7 +219,7 @@ private Set<Shard> deserializeShards(JsonNode jsonNode) {
for (JsonNode rangeNode : shardNode.get("ranges")) {
int start = rangeNode.get("start").asInt();
int end = rangeNode.get("end").asInt();
ranges.add(new ShardRange(start, end));
ranges.add(new ShardRange.Default(start, end));
}
shards.add(new Shard.Default(salt, ranges));
}
Expand Down
4 changes: 2 additions & 2 deletions example/src/main/java/cloud/eppo/androidexample/GsonConfigurationCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import cloud.eppo.api.dto.TargetingRule;
import cloud.eppo.api.dto.Variation;
import cloud.eppo.api.dto.VariationType;
import cloud.eppo.model.ShardRange;
import cloud.eppo.api.dto.ShardRange;
import com.google.gson.JsonArray;
import com.google.gson.JsonElement;
import com.google.gson.JsonNull;
Expand Down Expand Up @@ -543,7 +543,7 @@ private Set<Shard> deserializeShards(JsonElement element) {
if (rangesEl != null && rangesEl.isJsonArray()) {
for (JsonElement rangeEl : rangesEl.getAsJsonArray()) {
JsonObject range = rangeEl.getAsJsonObject();
ranges.add(new ShardRange(range.get("start").getAsInt(), range.get("end").getAsInt()));
ranges.add(new ShardRange.Default(range.get("start").getAsInt(), range.get("end").getAsInt()));
}
}
shards.add(new Shard.Default(salt, ranges));
Expand Down
4 changes: 2 additions & 2 deletions example/src/main/java/cloud/eppo/androidexample/GsonConfigurationParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import cloud.eppo.api.dto.TargetingRule;
import cloud.eppo.api.dto.Variation;
import cloud.eppo.api.dto.VariationType;
import cloud.eppo.model.ShardRange;
import cloud.eppo.api.dto.ShardRange;
import cloud.eppo.parser.ConfigurationParseException;
import cloud.eppo.parser.ConfigurationParser;
import com.google.gson.JsonArray;
Expand Down Expand Up @@ -269,7 +269,7 @@ private Set<Shard> deserializeShards(JsonElement element) {
JsonObject range = rangeElement.getAsJsonObject();
int start = range.get("start").getAsInt();
int end = range.get("end").getAsInt();
ranges.add(new ShardRange(start, end));
ranges.add(new ShardRange.Default(start, end));
}
}
shards.add(new Shard.Default(salt, ranges));
Expand Down
Loading