feat(python): add graceful shutdown method - #338
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 591a05e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dd-oleksii
changed the title
Collaborator
|
The CI error is unrelated to the PR |
leoromanovsky
approved these changes
Oct 13, 2025
Comment on lines
+56
to
+58
| let Ok(mut join_handle) = self.join_handle.lock() else { | ||
| return; | ||
| }; |
Member
There was a problem hiding this comment.
do you see any value in handling a poised mutex here? maybe with a warning log, if it is useful
Collaborator
Author
There was a problem hiding this comment.
Not really. The only way, the mutex can become poisoned is if the one line below panics (join_handle.take()) which it never does because it's a very simple operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.