feat(rust): add wait_for_configuration_timeout() method - #339
Merged
dd-oleksii merged 1 commit intoOct 13, 2025
Merged
dd-oleksii merged 1 commit into
dd-oleksii merged 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f67d165 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
The CI error is unrelated to the PR |
leoromanovsky
approved these changes
Oct 13, 2025
leoromanovsky
left a comment
leoromanovsky
left a comment
Member
There was a problem hiding this comment.
Good idea marking the other function deprecated
dd-oleksii
force-pushed
the
feat-rust-wait-for-configuration-timeout
branch
from
October 13, 2025 11:46
bb8de1f to
f67d165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
wait_for_configuration_timeout()method.In poor network conditions,
wait_for_configuration()may block waiting on configuration indefinitely which may be undesired. Add a newwait_for_configuration_timeout()which allows specifying a timeout for waiting.It used to be hard to implement because we didn't have shared async runtime (that's why we had indefinitely-blocking version initially). But now we have a shared async runtime, so handling timeouts is easier.