Skip to content

fix(FFESUPPORT-750): address open Dependabot vulnerabilities - #158

Merged
aarsilv merged 1 commit into
mainfrom
aarsilv/ffesupport-750/fix-vulnerabilities
Jun 2, 2026
Merged

fix(FFESUPPORT-750): address open Dependabot vulnerabilities#158
aarsilv merged 1 commit into
mainfrom
aarsilv/ffesupport-750/fix-vulnerabilities

Conversation

@aarsilv

@aarsilv aarsilv commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates Node relay/testing lockfiles and Yarn resolutions for the vulnerable transitive packages.
  • Updates symfony/cache and related Composer packages in the PHP relay lockfile.
  • Adds ws coverage in the React Native relay because the refreshed audit surfaced the same moderate ws advisory through Expo/jsdom tooling.

Dependabot alerts addressed

Verification

  • yarn install --frozen-lockfile at repo root.
  • yarn validate:tests
  • yarn obfuscate:ufc
  • yarn build in package-testing/testing-api
  • yarn install --frozen-lockfile and yarn audit --level moderate in each touched Node package directory.
  • yarn build and yarn test eppoClientProxy in package-testing/node-sdk-relay.
  • yarn test --watchAll=false in package-testing/react-native-sdk-relay.
  • composer install --no-interaction and composer audit in package-testing/php-sdk-relay.

Note: the full package-testing/node-sdk-relay Jest suite still fails in the existing app.controller bootstrap path because importing app.controller imports main and starts the Nest app during unit test collection; the dependency-focused eppoClientProxy test passes.

🤖 Generated with Codex

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency lockfiles and Yarn/Composer overrides across the relay test packages to remediate Dependabot-reported transitive vulnerabilities (Node/Yarn and PHP/Composer).

Changes:

  • Bumps transitive Node dependencies in Yarn lockfiles (e.g., qs, brace-expansion, fast-uri, ws) and adds targeted resolutions where needed.
  • Updates PHP relay Composer lockfile to newer Symfony cache-related packages.
  • Adds additional Yarn resolutions in the React Native relay to address ws surfaced by refreshed audits.

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package-testing/testing-api/yarn.lock Updates transitive Node packages (e.g., brace-expansion, qs) to patched versions.
package-testing/testing-api/package.json Adds Yarn resolutions to force patched qs.
package-testing/react-native-sdk-relay/yarn.lock Updates transitive packages (e.g., brace-expansion, fast-uri, ws) to patched versions.
package-testing/react-native-sdk-relay/package.json Adds Yarn resolutions for fast-uri and ws.
package-testing/php-sdk-relay/composer.lock Updates Symfony cache stack and related packages in the lockfile.
package-testing/node-sdk-relay/yarn.lock Updates transitive packages (e.g., brace-expansion, fast-uri, qs) to patched versions.
package-testing/node-sdk-relay/package.json Adds Yarn resolutions for fast-uri and qs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aarsilv
aarsilv force-pushed the aarsilv/ffesupport-750/fix-vulnerabilities branch from 7488f99 to 3eb1d10 Compare May 29, 2026 03:05
@aarsilv
aarsilv requested a review from Copilot May 29, 2026 03:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated 2 comments.

Comment on lines +70 to +73
"//uuid": "GHSA-9c47-m6qq-7p4h: pin to ^14 — older versions pulled by @eppo/js-client-sdk-common transitively",
"uuid": "^14"
"uuid": "^14",
"fast-uri": "^3.1.2",
"ws": "^8.20.1"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Response from AI: Resolved in the current head by adding explicit resolutionRationales metadata for the react-native relay overrides instead of adding fake package patterns inside resolutions. Strict install and audit pass.

Comment on lines +58 to +60
"uuid": "^14",
"fast-uri": "^3.1.2",
"qs": "^6.15.2"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Response from AI: Resolved in the current head by adding resolutionRationales for uuid, fast-uri, and qs while keeping resolutions limited to actual package selectors. Strict install and audit pass.

@aarsilv
aarsilv force-pushed the aarsilv/ffesupport-750/fix-vulnerabilities branch from 3eb1d10 to bc5517d Compare May 29, 2026 03:17
@aarsilv
aarsilv requested a review from Copilot May 29, 2026 03:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated no new comments.

@aarsilv

aarsilv commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Context from Codex: This updates vulnerable Node relay/test package transitives plus the PHP relay Symfony cache stack. Validation covered root yarn validate:tests, yarn obfuscate:ufc, strict installs/builds/audits for affected JS fixtures, React Native Jest, and composer audit. The full node-sdk-relay suite still hits the pre-existing app.controller bootstrap path, so I verified the dependency-sensitive eppoClientProxy test directly. Copilot is clean.

@aarsilv
aarsilv force-pushed the aarsilv/ffesupport-750/fix-vulnerabilities branch from bc5517d to 0db679b Compare May 29, 2026 15:34
@aarsilv
aarsilv requested a review from Copilot May 29, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.

Comment on lines 23 to +27
export default function getLogger(): RelayLogger {
return logger;
}

bootstrap();
if (require.main === module) {
@aarsilv
aarsilv merged commit 3fe258b into main Jun 2, 2026
1 check passed
@aarsilv
aarsilv deleted the aarsilv/ffesupport-750/fix-vulnerabilities branch June 2, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants