fix(FFESUPPORT-750): address open Dependabot vulnerabilities - #158
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependency lockfiles and Yarn/Composer overrides across the relay test packages to remediate Dependabot-reported transitive vulnerabilities (Node/Yarn and PHP/Composer).
Changes:
- Bumps transitive Node dependencies in Yarn lockfiles (e.g.,
qs,brace-expansion,fast-uri,ws) and adds targetedresolutionswhere needed. - Updates PHP relay Composer lockfile to newer Symfony cache-related packages.
- Adds additional Yarn
resolutionsin the React Native relay to addresswssurfaced by refreshed audits.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package-testing/testing-api/yarn.lock | Updates transitive Node packages (e.g., brace-expansion, qs) to patched versions. |
| package-testing/testing-api/package.json | Adds Yarn resolutions to force patched qs. |
| package-testing/react-native-sdk-relay/yarn.lock | Updates transitive packages (e.g., brace-expansion, fast-uri, ws) to patched versions. |
| package-testing/react-native-sdk-relay/package.json | Adds Yarn resolutions for fast-uri and ws. |
| package-testing/php-sdk-relay/composer.lock | Updates Symfony cache stack and related packages in the lockfile. |
| package-testing/node-sdk-relay/yarn.lock | Updates transitive packages (e.g., brace-expansion, fast-uri, qs) to patched versions. |
| package-testing/node-sdk-relay/package.json | Adds Yarn resolutions for fast-uri and qs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7488f99 to
3eb1d10
Compare
| "//uuid": "GHSA-9c47-m6qq-7p4h: pin to ^14 — older versions pulled by @eppo/js-client-sdk-common transitively", | ||
| "uuid": "^14" | ||
| "uuid": "^14", | ||
| "fast-uri": "^3.1.2", | ||
| "ws": "^8.20.1" |
There was a problem hiding this comment.
🤖 Response from AI: Resolved in the current head by adding explicit resolutionRationales metadata for the react-native relay overrides instead of adding fake package patterns inside resolutions. Strict install and audit pass.
| "uuid": "^14", | ||
| "fast-uri": "^3.1.2", | ||
| "qs": "^6.15.2" |
There was a problem hiding this comment.
🤖 Response from AI: Resolved in the current head by adding resolutionRationales for uuid, fast-uri, and qs while keeping resolutions limited to actual package selectors. Strict install and audit pass.
3eb1d10 to
bc5517d
Compare
|
🤖 Context from Codex: This updates vulnerable Node relay/test package transitives plus the PHP relay Symfony cache stack. Validation covered root |
bc5517d to
0db679b
Compare
| export default function getLogger(): RelayLogger { | ||
| return logger; | ||
| } | ||
|
|
||
| bootstrap(); | ||
| if (require.main === module) { |
Summary
symfony/cacheand related Composer packages in the PHP relay lockfile.wscoverage in the React Native relay because the refreshed audit surfaced the same moderatewsadvisory through Expo/jsdom tooling.Dependabot alerts addressed
symfony/cacheadvisories inpackage-testing/php-sdk-relay/composer.lock, updated to 6.4.41.qsGHSA-q8mj-m7cp-5q26, patched in 6.15.2.brace-expansionnpm advisory 1119088 / GHSA-v6h2-p8h4-qcjw, patched in 5.0.6 where affected.fast-uriGHSA-v39h-62p7-jpjc and GHSA-q3j6-qgpj-74h6, patched in 3.1.2.Verification
yarn install --frozen-lockfileat repo root.yarn validate:testsyarn obfuscate:ufcyarn buildinpackage-testing/testing-apiyarn install --frozen-lockfileandyarn audit --level moderatein each touched Node package directory.yarn buildandyarn test eppoClientProxyinpackage-testing/node-sdk-relay.yarn test --watchAll=falseinpackage-testing/react-native-sdk-relay.composer install --no-interactionandcomposer auditinpackage-testing/php-sdk-relay.Note: the full
package-testing/node-sdk-relayJest suite still fails in the existingapp.controllerbootstrap path because importingapp.controllerimportsmainand starts the Nest app during unit test collection; the dependency-focusedeppoClientProxytest passes.🤖 Generated with Codex