fix(FFESUPPORT-892): bump php-sdk-relay to eppo/php-sdk ^4.0 - #161
Merged
Conversation
The relay pinned eppo/php-sdk ^3.2 (locked v3.5.1) while php-sdk is now v4.x
(v4.2.1). The test-server-package action installs the pinned deps then overlays
the tested branch's v4.x source, so the relay ran 4.x code against 3.x-resolved
deps and crashed ('SDK Relay server failed to start') — failing php-sdk's
package-integration CI (green on main until php-sdk went 4.x). Bump to ^4.0
(locks v4.2.1). Relay src is BC: all src/*.php lint clean and the client/Config
construct against v4. Unblocks php-sdk PR #62's integration job.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the package-testing/php-sdk-relay harness dependencies so it can run against eppo/php-sdk v4.x, resolving the integration test failure caused by overlaying v4 source onto a v3-resolved vendor tree.
Changes:
- Bump
eppo/php-sdkrequirement from^3.2to^4.0in the relay’scomposer.json. - Regenerate
composer.lockto lockeppo/php-sdkatv4.2.1(and reflect its updated transitive requirements).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package-testing/php-sdk-relay/composer.json | Updates the relay’s SDK dependency constraint to eppo/php-sdk:^4.0. |
| package-testing/php-sdk-relay/composer.lock | Locks updated dependency graph for php-sdk v4 (notably eppo/php-sdk v4.2.1). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
typotter
approved these changes
Jul 20, 2026
typotter
left a comment
typotter
left a comment
Collaborator
There was a problem hiding this comment.
Fixes the php-sdk-relay test harness so it works with php-sdk v4.x.
🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated from Claude
Fixes the
php-sdk-relaytest harness so it works with php-sdk v4.x. Jira: https://datadoghq.atlassian.net/browse/FFESUPPORT-892Problem
php-sdk's "Package Integration Testing" CI (via this repo's
test-server-packageaction +php-sdk-relay) fails deterministically with "SDK Relay server failed to start" (green onmainuntil 2026-05-26). The relay'scomposer.jsonpinnedeppo/php-sdk: ^3.2(locking v3.5.1), but php-sdk is now v4.x. The actioncomposer installs the pinned 3.x deps, then overlays the tested branch's v4.x source onto that 3.x vendor tree → the relay runs 4.x code against 3.x-resolved dependencies → crash → port 4000 never comes up. (Surfaced while remediating php-sdk vulns in php-sdk#62, but unrelated to it — that PR is composer.lock-only.)Fix
Bump the relay's
eppo/php-sdkconstraint^3.2 → ^4.0and regeneratecomposer.lock(eppo/php-sdk v3.5.1 → v4.2.1). No relaysrc/changes needed.Verification (local, PHP 8.5)
composer require eppo/php-sdk:^4.0resolves cleanly;composer auditreports no advisories.src/*.phplint clean (php -l); the client /Configconstruct against v4.main; re-running php-sdk#62's integration job will then go green.Scope
package-testing/php-sdk-relay/composer.json+composer.lockonly.