Open
Conversation
shank-eric
reviewed
Mar 10, 2026
package.json
Outdated
| "glob-parent": "^5.1.2", | ||
| "micromatch": "^4.0.6" | ||
| "micromatch": "^4.0.6", | ||
| "minimatch": "^3.1.5" |
There was a problem hiding this comment.
this seems unnecessary and is forcing the version down for some dependencies
… 2.0.2 in package.json and yarn.lock
shank-eric
reviewed
Mar 11, 2026
| "glob-parent": "^5.1.2", | ||
| "micromatch": "^4.0.6" | ||
| "micromatch": "^4.0.6", | ||
| "minimatch": "^5.1.8" |
There was a problem hiding this comment.
now you're forcing lower versions to a higher version number. You need to be sure to target the specific use/version that's locked and only set a resolution for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
Snyk Fixes
Does it fix an existing ticket?
https://dev.azure.com/everfi-dev/Platform/_workitems/edit/34274
Yes/No #000
Checklist
yarn test(see details here)