-
Notifications
You must be signed in to change notification settings - Fork 2
batch takes args #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
batch takes args #29
Conversation
|
e.g. would do the job for 64*1024 shots, 4 micron crystals, and add the word cyto to the jobname and output folder.. job name would be Maybe we want to change the folder from $CFS/m2859/cytochrome to something else (or make that a cmd line arg) |
|
@dermen I'd like a Thurs-morning Zoom call to discuss. I'd be interested in modifying the script in a different direction aimed at eliminating the script differences between protein cases. Here's my analysis of the full set of differences (only figured out for cyto & Cry11ba so far): Can't seem to share table... Will return to the issue |
|
@irisdyoung I have several concerns about your recent commit. One, I can't see where $detdist is initially defined. Also, there should be a document or README that explicitly lists the parameter values for all 4 cases. We simply can't let this important knowledge get lost in the shuffle of indirection. |
|
@nksauter my last commit added the documentation you described. Does this address your concerns? |
|
No. Instead, I implemented an alternate generalized command script that is
now in post-validate/general. There are a few bugfixes I'll check in
within an hour. I recommend converging around the general/ scripts.-Nick
…On Tue, Dec 5, 2023 at 1:07 AM Iris Young ***@***.***> wrote:
@nksauter <https://github.com/nksauter> my last commit added the
documentation you described. Does this address your concerns?
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ24VXQNIXP4ZYNZEPLSE3YH3P6XAVCNFSM6AAAAABAAI54VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBQGMYTMOJUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.