Skip to content

Fix failing test on MacOS with julia 1.0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Expander wants to merge 3 commits into from
Closed

Fix failing test on MacOS with julia 1.0 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8284196
run only on macOS with julia 1.0
Expander Nov 14, 2025
5212b82
inline euler gamma constant
Expander Nov 14, 2025
94f0d33
use pre-defined eulergamma
Expander Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
strategy:
matrix:
arch: [x64]
os: [ubuntu-latest, macOS-latest, Windows-latest]
version: ['1.0', '1']
os: [macOS-latest]
version: ['1.0']

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 0 additions & 1 deletion src/Constants.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ const ZETA3_F64 = 1.2020569031595943 # zeta(3) with Float64 precision
const ZETA4_F64 = 1.0823232337111382 # zeta(4) with Float64 precision
const ZETA5_F64 = 1.0369277551433699 # zeta(5) with Float64 precision
const ZETA6_F64 = 1.0173430619844491 # zeta(6) with Float64 precision
const EULERGAMMA_F64 = 0.57721566490153286 # Euler gamma constant with Float64 precision
2 changes: 1 addition & 1 deletion src/Harmonic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function harmonic(n::Integer, ::Type{T})::T where T
elseif n == 1
one(T)
elseif issimplefloat(T) && n >= 20
convert(T, EULERGAMMA_F64 + digamma(n + 1))
convert(T, Base.MathConstants.eulergamma + digamma(n + 1))
else
one(T) + sum(x -> inv(T(x)), 2:n)
end
Expand Down
Loading