Track all commit waits, including no wait - #2694
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| if (waited) { | ||
| SINFO("Waited " << chrono::duration_cast<chrono::microseconds>(elapsed) << " for commit lock."); | ||
| } else { | ||
| SINFO("Acquired commit lock immediately."); |
There was a problem hiding this comment.
Hmmm maybe we should remove this and log the elapsed every time? That way graph is still correct as it would track 0?
There was a problem hiding this comment.
I think it may still track 0 though. I'm not sure how likely it is we can get 0us as a time when we waited, but I wouldn't doubt that it's possible, and that's a different case from successfully getting the lock on the first try. It might not be enough of a difference to matter, but I feel this provides more info. I could change it though, I'm not sure if the increase in accuracy makes a real difference.
Co-authored-by: Ionatan Wiznia <ionatan@expensify.com>
|
@MelvinBot - create an issue, make it weekly, assign it to me. It should be to undo this change after we've gathered the required data to see how long we spend waiting on this lock. |
2 participants
Details
For diagnostic purposes, we want to see how much time we can remove from committing with HC-Tree not requiring waiting on a commit lock.
Fixed Issues
Fixes GH_LINK
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes