Skip to content

Fix stale workspace lock triage#655

Merged
chubes4 merged 1 commit into
mainfrom
fix/issue-650-stale-lock-triage
Jun 12, 2026
Merged

Fix stale workspace lock triage#655
chubes4 merged 1 commit into
mainfrom
fix/issue-650-stale-lock-triage

Conversation

@chubes4

@chubes4 chubes4 commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Surface stale workspace lock follow-up in cleanup status and hygiene reports with exact preview/apply prune commands.
  • Expand lock status rows to explain DB vs filesystem stale state, owner/session age evidence, live flock presence, and safe-to-prune state.
  • Protect expired DB lock rows from pruning when the matching filesystem lock still has a live flock.

Verification

  • php -l inc/Workspace/WorkspaceLockStore.php && php -l inc/Workspace/WorkspaceMutationLock.php && php -l inc/Workspace/WorkspaceHygieneReport.php && php -l inc/Cli/Commands/WorkspaceCommand.php && php -l tests/smoke-workspace-mutation-lock.php && php -l tests/smoke-workspace-hygiene-report.php && php -l tests/smoke-worktree-cleanup-cli.php
  • php tests/smoke-workspace-mutation-lock.php
  • php tests/smoke-workspace-hygiene-report.php
  • php tests/smoke-worktree-cleanup-cli.php
  • git diff --check

Fixes #650.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Implemented stale workspace lock reporting/prune safety changes, added focused smoke coverage, and ran targeted verification; Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — failed

ℹ️ Auto-fix: homeboy lint data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since f9eac72 --fix (or homeboy refactor data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since f9eac72 --from lint --write)
ℹ️ Some issues may require manual fixes
ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since f9eac72

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27392386267

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Save test baseline: homeboy test data-machine-code --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since f9eac72

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27392386267

Audit

audit — passed

  • audit — 41 finding(s)
  • Total: 41 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since f9eac72

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27392386267
Tooling versions
  • Homeboy CLI: homeboy 0.228.13+73ed853
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 19cdd6a5
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 08c5cc6 into main Jun 12, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stale workspace locks need a safe report and prune workflow tied to cleanup triage

1 participant