Skip to content

Fix cleanup plan local worktree signals#659

Merged
chubes4 merged 2 commits into
mainfrom
fix-cleanup-plan-local-signals
Jun 12, 2026
Merged

Fix cleanup plan local worktree signals#659
chubes4 merged 2 commits into
mainfrom
fix-cleanup-plan-local-signals

Conversation

@chubes4

@chubes4 chubes4 commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Let retention cleanup planning run local worktree merge/remote-clean signal detection instead of inventory-only metadata classification.
  • Update the human cleanup-plan label so operators can see that retention planning uses local worktree merge signals while still skipping artifact scans by default.
  • Add a smoke assertion that a clean active remote-backed worktree is promoted into cleanup-plan removal rows instead of falling through to active/no-signal resolver rows.

Testing

  • php tests/smoke-worktree-cleanup-cli.php
  • php -l inc/Workspace/WorkspaceCleanupPlan.php
  • php -l inc/Cli/Commands/WorkspaceCommand.php
  • php -l tests/smoke-worktree-cleanup-cli.php
  • php -l tests/smoke-worktree-cleanup.php
  • php tests/smoke-worktree-cleanup.php currently reports 152/161 passed; the new cleanup-plan assertion passes, while existing duplicate dirty/external skip-count expectations still fail outside this change.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Investigated the cleanup planning classification bug, drafted the code/test changes, and ran local verification commands for Chris to review.

@homeboy-ci

homeboy-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 96c0220

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27414130556

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Save test baseline: homeboy test data-machine-code --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 96c0220

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27414130556

Audit

audit — passed

  • audit — 32 finding(s)
  • Total: 32 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 96c0220

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27414130556
Tooling versions
  • Homeboy CLI: homeboy 0.228.15+20b3d24
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: cdc3d9dd
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 4a7c58e into main Jun 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant