refactor: consolidate duplicate PromptField onto canonical shared copy#2210
Merged
Conversation
…red/components copy The Pipelines copy at inc/Core/Admin/Pages/Pipelines/assets/react/components/shared/PromptField.jsx was a near-identical duplicate of inc/Core/Admin/shared/components/PromptField.jsx (the only difference was that the Pipelines copy imported AUTO_SAVE_DELAY from a constants module while the canonical inlined the same 500ms value). No imports actually referenced the duplicate — both real consumers (PipelineStepCard, SystemTasksTab) already import via the @shared/components/PromptField webpack alias, which resolves to the canonical file. The duplicate was dead code. Part of #2209 (phase 1 step 1). No behavior change; build verified clean.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #2209 (phase 1 step 1).
Changes
inc/Core/Admin/Pages/Pipelines/assets/react/components/shared/PromptField.jsxPipelineStepCard,SystemTasksTab) already imported via the@shared/components/PromptFieldwebpack alias, which resolves to the canonical file. The duplicate was dead code.npm run build, zero errors/warnings).Diff summary
The two files were near-identical. The only difference: the Pipelines copy imported
AUTO_SAVE_DELAYfrom../../utils/constantswhile the canonical inlined the same 500ms value. Functionally equivalent.Out of scope
useAutosavehook from Design: shared useAutosave hook + framework-agnostic core for consistent debounced persistence across the network extrachill-components#4) — separate issue.