Skip to content

fix: add drain timeout margin#2234

Merged
chubes4 merged 1 commit into
mainfrom
fix/drain-stop-before-timeout
May 24, 2026
Merged

fix: add drain timeout margin#2234
chubes4 merged 1 commit into
mainfrom
fix/drain-stop-before-timeout

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 24, 2026

Summary

  • Adds --stop-before-timeout to wp datamachine drain so local drains can exit before an external timeout kills the process.
  • Reports stop_reason from drain runs, including timeout_margin, so JSON/table output explains why the drain stopped.
  • Updates WP-CLI docs and smoke coverage for the new option.

Verification

  • php -l inc/Cli/Commands/DrainCommand.php
  • php tests/flow-run-cli-drain-smoke.php

Linked issues

Notes

  • homeboy lint --path /Users/chubes/Developer/data-machine@fix-drain-stop-before-timeout --extension wordpress could not run because the local Homeboy extension registry does not have the wordpress extension linked, even though this component declares it.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosing the CLI gap, drafting the implementation, updating smoke coverage/docs, and running local verification. Chris remains responsible for review and merge.

@chubes4 chubes4 merged commit 0d167c1 into main May 24, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/drain-stop-before-timeout branch May 24, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stop-before-timeout support to local drain command

1 participant