Skip to content

FTB Quests - EMI integration#9

Draft
unilock wants to merge 2 commits into
FTBTeam:1.19/devfrom
unilock:1.19/dev-emi
Draft

FTB Quests - EMI integration#9
unilock wants to merge 2 commits into
FTBTeam:1.19/devfrom
unilock:1.19/dev-emi

Conversation

@unilock

@unilock unilock commented Sep 7, 2023

Copy link
Copy Markdown

This PR adds integration with EMI, a new-ish recipe viewer, to FTB Quests. Fixes FTBTeam/FTB-Mods-Issues#312.

TODO:

  • Clicking items in the Quest Book UI opens EMI
  • Display quest rewards in EMI under a new category
    • Fix category sometimes not appearing in EMI until after /reload - seems to be dependent on mod load order? (which, afaik, is random in Fabric)
    • Center the quest title text
    • Maybe use something other than our own ClickableTextWidget for opening the quest book from EMI?
  • Display "loot crates" in EMI under a new category

Note: the modpack I'm using for testing is @sisby-folk's Tinkerer's Quilt.

Signed-off-by: unilock <unilock@fennet.rentals>
Sometimes only works after /reload?

Signed-off-by: unilock <unilock@fennet.rentals>
@desht

desht commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

I'll be following this with interest, thanks for taking the time on this. Feel free to tag me with any questions, if needed.

@Spongman

Spongman commented Jun 1, 2024

Copy link
Copy Markdown

can you also add EMI bookmark support directly from the quest 'Tasks' or 'Valid Items' page ?

@Kevin-Marsh

Copy link
Copy Markdown

I will be curious to see how this goes. A few mods have dropped JEI support in 1.21 which has basically forced the adoption of EMI with ATM10 using straight EMI to start out and Enigmatica 10 using a combination of JEI and EMI.

@unilock

unilock commented Jul 6, 2024

Copy link
Copy Markdown
Author

@Spongman

can you also add EMI bookmark support directly from the quest 'Tasks' or 'Valid Items' page ?

This is not something EMI exposes an API for, currently.

@monochromem1nd

Copy link
Copy Markdown

@unilock Do you have any ideas on how to make it so that instead of opening inventory, pressing ESC opens the quest from where the recipe display was opened, if at all possible?

@MycahBrooks

Copy link
Copy Markdown

hey! is this PR still being worked on?

@sarpuser

Copy link
Copy Markdown

I am also very interested in this pull request.

@SanQianQVQ

Copy link
Copy Markdown

I'm not sure if the problem has been solved, because I still encounter this problem
emi-1.1.12+1.20.1+fabric
ftb-quests-fabric-2001.4.8
ftb-xmod-compat-fabric-2.1.1
Frustrating

@xaqbr

xaqbr commented Apr 18, 2025

Copy link
Copy Markdown

Is there any progress on this? Compiling the mod from your forked source gives me dependency errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants